Setting up npm build #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👌 |
Why: - To allow us to work on the component using JSX and ES6, which increases maintainability and allows others to more easily contribute - To allow users to require either the built or unbuilt version of the component What: - Added a 'build-npm' script and used it in the 'prepublish' script for npm - Use babel in the build script to parse ES6 and JSX - Add some ES6 and JSX to our component's source, now that we can - Save built version of component in 'build/npm/waypoint.js' - Point the 'main' entry point for npm at 'build/npm/waypoint.js' - Inline the webpack configs into the 'karma.conf.js' and remove cruft - Changed some require paths to work with new build system - Added 'jsx' syntax and extension to 'waypoint' unbuilt version. How: > npm run build-npm This release also contains a fix for a bug where the 'resize' event was possibly missed when we had a 'scrollableParent' other than the window.
flarnie
force-pushed
the
setting_up_npm_build
branch
from
96add54
to
a62799c
Compare
flarnie
added a commit
that referenced
this pull request
Apr 14, 2015
Setting up npm build; releasing version 1.0
lencioni
added a commit
that referenced
this pull request
Jun 18, 2018
None of the changes affect how consolidated-events is used in react-waypoint. Changelog: - Now built with rollup ([#8](lencioni/consolidated-events#8)) - Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13)) - Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11)) - Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.